From e9bc288e35703860fc3c175c95cdd2f32435419f Mon Sep 17 00:00:00 2001 From: NullBite <me@nullbite.com> Date: Tue, 4 Mar 2025 01:25:36 -0500 Subject: [PATCH] ci: eval builds as single attrset This is much safer and might also be faster. Passing `system` could still be hypothetically unsafe, but I doubt nixpkgs will ever have a system name with a dot in it for this specific reason. --- ci/run_builds.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ci/run_builds.sh b/ci/run_builds.sh index 5654288..2cae730 100755 --- a/ci/run_builds.sh +++ b/ci/run_builds.sh @@ -47,14 +47,14 @@ build_systems () { # system should be set in `nix develop` but just in case local system system="${system:-$(nix eval --impure --raw --expr 'builtins.currentSystem')}" - nix eval --json .#legacyPackages."${system}".specialisedNixosConfigurations --apply 'builtins.attrNames' \ - | jq -c '.[]' \ - | while read -r line ; do - local build - build="$(printf '%s' "$line" | jq -r)" - run_builds ".#legacyPackages.${system}.specialisedNixosConfigurations.${build}" - done - # run_builds ".#legacyPackages.${system}.specialisedNixosConfigurations" + #nix eval --json .#legacyPackages."${system}".specialisedNixosConfigurations --apply 'builtins.attrNames' \ + # | jq -c '.[]' \ + # | while read -r line ; do + # local build + # build="$(printf '%s' "$line" | jq -r)" + # run_builds ".#legacyPackages.${system}.specialisedNixosConfigurations.${build}" + # done + run_builds ".#legacyPackages.${system}.specialisedNixosConfigurations" }