From d9dad28acf984b3b07bdee83195571da835f4306 Mon Sep 17 00:00:00 2001
From: NullBite <me@nullbite.com>
Date: Sat, 4 Jan 2025 01:16:41 -0500
Subject: [PATCH] rpi4: don't set PATH using shell exports

what the actual fuck was i cooking
---
 hosts/rpi4/media-sync.nix | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/hosts/rpi4/media-sync.nix b/hosts/rpi4/media-sync.nix
index e06b0dd..19ef31e 100644
--- a/hosts/rpi4/media-sync.nix
+++ b/hosts/rpi4/media-sync.nix
@@ -14,16 +14,11 @@ in {
       };
     };
     systemd.services.gallery-dl = {
-      script = ''
-        PATH=${with pkgs; lib.escapeShellArg (lib.makeBinPath [ bash coreutils findutils gallery-dl ])}
-        export PATH
-
+      environment.PATH = with pkgs; makeBinpath [ bash coreutils findutils gallery-dl ];
+      serviceConfig = {
         # none of your fucking business
         # TODO move this into an agenix secret probably
-        exec /srv/gallery-dl.sh
-      '';
-
-      serviceConfig = {
+        ExecStart = "/srv/gallery-dl.sh";
         Type = "oneshot";
         User = "nullbite";
       };
@@ -37,13 +32,10 @@ in {
       };
     };
     systemd.services.gallery-dl-dedup = {
-      script = ''
-        PATH=${with pkgs; lib.escapeShellArg (lib.makeBinPath [ coreutils rmlint ])}
-        export PATH
-
-        exec /srv/gallery-dl-dedup.sh
-      '';
+      environment.PATH = with pkgs; makeBinpath [ bash coreutils rmlint ];
       serviceConfig = {
+        # likewise
+        ExecStart = "/srv/gallery-dl-dedup.sh";
         Type = "oneshot";
         User = "nullbite";
       };